Pull request overview

This pull request implements follow-up improvements to the AampUnderflowMonitor feature, focusing on lifecycle management changes and code simplification. However, the PR introduces critical thread-safety issues by removing mutex protections that were essential for safe concurrent access.

Changes:

• Moved AampUnderflowMonitor initialization from lazy creation in StartUnderflowMonitor to eager creation in StreamAbstractionAAMP constructor
• Removed mUnderflowMonitorMutex from StreamAbstractionAAMP class and all lifecycle method synchronization
• Cached raw pointers in AampUnderflowMonitor::Run() method to avoid repeated mutex locking
• Renamed parameter from bufferingStopped to bufferingStart for clarity
• Added config check wrapper around SetBufferingState logic
• Moved StartUnderflowMonitor calls from central TuneHelper to protocol-specific Start() methods

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 10 comments.

	if (mUnderflowMonitor)
	{
		mUnderflowMonitor->Stop();
		mUnderflowMonitor.reset();
		AAMPLOG_INFO("Stopped AampUnderflowMonitor for video");
	}

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 7 comments.

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 6 comments.

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.

#include "AampUnderflowMonitor.h"
#include "MockAampUnderflowMonitor.h"

MockAampUnderflowMonitor *g_mockAampUnderflowMonitor = nullptr;

AampUnderflowMonitor::AampUnderflowMonitor(StreamAbstractionAAMP* stream, PrivateInstanceAAMP* aamp) : mStream(stream), mAamp(aamp)
{
}

AampUnderflowMonitor::~AampUnderflowMonitor()
{
}

void AampUnderflowMonitor::Start()
{
    mRunning.store(true);
    if(g_mockAampUnderflowMonitor != nullptr)
    {
        g_mockAampUnderflowMonitor->Start();
    }
}

void AampUnderflowMonitor::Stop()
{
    mRunning.store(false);
    if(g_mockAampUnderflowMonitor != nullptr)
    {
        g_mockAampUnderflowMonitor->Stop();
    }
}

void AampUnderflowMonitor::Run()
{
}

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 5 comments.

protected:
	/**
	 * Underflow monitor instance owned by Stream; manages detection and
	 * handling of underflow conditions.
	 */
	std::unique_ptr<class AampUnderflowMonitor> mUnderflowMonitor;